openthread: platform: radio_spinel: Spinel variables on global memory #97032
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
canisLupus1313,
edmont,
maciejbaczmanski,
mariuszpos,
pdgendt and
rlubos
rlubos
reviewed
Oct 6, 2025
| #endif | ||
| OT_RADIO_CAPS_ACK_TIMEOUT | OT_RADIO_CAPS_TRANSMIT_RETRIES | OT_RADIO_CAPS_CSMA_BACKOFF; | ||
|
|
||
| inline void *operator new(size_t, void *p) noexcept { |
There was a problem hiding this comment.
Why is it needed to override the standard new? But anyway, I see OT does the same, so maybe just reuse the one that OT uses?
https://github.com/zephyrproject-rtos/openthread/blob/2bc7712f57af22058770d1ef131ad3da79a0c764/src/include/common/new.hpp#L41
There was a problem hiding this comment.
Thanks for pointing this, I was not aware of it. I've overridden the new operator because app did not compile in our case, where PICOLIBC is enabled. Added header from OT and updated the PR.
Cristib05
force-pushed
the
place_spinel_impl_on_global_memory
branch
from
573b9d1 to
91c33c5
Compare
pdgendt
reviewed
Oct 6, 2025
This commits aims to move spinel related variables from heap to global arrays. In this way, HEAP_MEM_POOL_ADD_SIZE_ does not need to be defined, or updated if any change in data structure might occur. Signed-off-by: Cristian Bulacu <[email protected]>
Cristib05
force-pushed
the
place_spinel_impl_on_global_memory
branch
from
91c33c5 to
413af16
Compare
|
rlubos
approved these changes
Oct 6, 2025
pdgendt
approved these changes
Oct 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit aims to move spinel related variables from heap to global arrays. Main reason behind this decision is that spinel variables are required for the entire lifetime of application.
In this way, HEAP_MEM_POOL_ADD_SIZE_ does not need to be defined, or updated, if any change in data structure might occur.